Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to set custom headers using only the keyboard when fetching urls #5886

Merged
merged 1 commit into from Jun 4, 2023
Merged

Make it possible to set custom headers using only the keyboard when fetching urls #5886

merged 1 commit into from Jun 4, 2023

Conversation

Abbe98
Copy link
Member

@Abbe98 Abbe98 commented Jun 1, 2023 •
edited

This swaps a custom <details> implementation for a HTML based one making it keyboard accessiable.

@Abbe98
Make it possible to set custom headers using only the keyboard when f…
80091c8 
…etching urls

This swaps a custom <details> implementation for a HTML based one making it keyboard accessiable.
@Abbe98
Copy link
Member Author

Abbe98 commented Jun 1, 2023

Screencast.from.2023-06-01.08-55-00.webm

wetneb
wetneb approved these changes Jun 2, 2023
View reviewed changes
Copy link
Sponsor Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I did not know about those HTML tags. Very cool! And also happy to get rid of the animation there, I think it was not very fitting.

@wetneb wetneb merged commit 876efdb into OpenRefine:master Jun 4, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Abbe98 @wetneb