-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made CI skip Coveralls if Java files aren't changed #5912
Conversation
Would it not be cleaner to use the native path filtering options for that? It would avoid spinning up a job just to do this computation. It looks like this is only available for the entire workflow, and not an individual job, but perhaps we could just split the |
I'm not sure, it seems more complicated to split it into multiple workflows, but maybe because I haven't seen it done that way. I just got it working but I need to try changing a Java source file to see if the Java tests and Coveralls report runs correctly. I'll do that tomorrow. Let me know by tomorrow if you want me to continue on this. Thanks, |
To me it seems simpler for the following reasons:
|
If we change windows_server_test to always skip the Java tests, then you could move the check_java_src_changes into the linux_server_test and avoid creating another job. I had to have as a separate job because both the Windows and Linux tests were using the result. But if you are saying to skip all server tests if no Java code is changed, and to rely on the e2e tests, I wasn't thinking that is possible but maybe it is ok. I thought there may be cases where you make some change that isn't in the Java source directory, the server tests should still be run to make sure nothing got broken, like if the refine or refine.bat script is modified. |
For sure the list of files I mentioned in #5912 is not exhaustive - it does make sense to add Once we detect that no changes were made to the files, we should not have to run any |
Part of #5909.
Added job that gets the list of changed files and checks if any are within one of the java directories, then changed=true, otherwise false.
If the Java source is changed, then Java tests are run and the Coveralls report is run.
Changes proposed in this pull request: