Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import to support lower versions of Nodejs #5916

Closed
wants to merge 6 commits into from

Conversation

5tigerjelly
Copy link
Contributor

Fixes #5880

Changes proposed in this pull request:

  • update import

@wetneb
Copy link
Sponsor Member

wetneb commented Jun 13, 2023

Thanks! Looking at the CI, it seems that your new version fails to install our frontend dependencies (notably, jQuery) so the app is not functional anymore with this change.

@Abbe98
Copy link
Member

Abbe98 commented Jun 14, 2023

Shouldn't we prefer to stick with ES6 here? Going back to non standard CommonJS feels backwards to me. require and import also work slightly differently.

@wetneb
Copy link
Sponsor Member

wetneb commented Jun 14, 2023

That would be fine for me too! Do you happen to know what minimum version of nodejs this entails, so that we could document that?

@Abbe98
Copy link
Member

Abbe98 commented Jun 14, 2023

That would be fine for me too! Do you happen to know what minimum version of nodejs this entails, so that we could document that?

I'm guessing version 17 which translates into 18 given that 17 is EOL. Maybe the easiest solution(given we wont test all versions) is to say that latest LTS and newer versions are supported.

@wetneb
Copy link
Sponsor Member

wetneb commented Jun 14, 2023

I can say it works with NodeJS 16 so that's an upper bound on the requirement :)

@wetneb
Copy link
Sponsor Member

wetneb commented Jun 14, 2023

Let's close this and document that Nodejs >= 16 is required to compile OpenRefine. If anyone is aware of an earlier version which also works, we can change that.

@wetneb wetneb closed this Jun 14, 2023
wetneb added a commit to OpenRefine/openrefine.org that referenced this pull request Jun 14, 2023
wetneb added a commit to OpenRefine/openrefine.org that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running into dependency issue on Linux
3 participants