-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update import to support lower versions of Nodejs #5916
Conversation
Thanks! Looking at the CI, it seems that your new version fails to install our frontend dependencies (notably, jQuery) so the app is not functional anymore with this change. |
Shouldn't we prefer to stick with ES6 here? Going back to non standard CommonJS feels backwards to me. |
That would be fine for me too! Do you happen to know what minimum version of nodejs this entails, so that we could document that? |
|
I can say it works with NodeJS 16 so that's an upper bound on the requirement :) |
Let's close this and document that Nodejs >= 16 is required to compile OpenRefine. If anyone is aware of an earlier version which also works, we can change that. |
Fixes #5880
Changes proposed in this pull request: