Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove dependency of history entry tests to column addition operation #6573

Merged

Conversation

wetneb
Copy link
Sponsor Member

@wetneb wetneb commented Apr 28, 2024

Another change that's in the way of Maven modularization.
The HistoryEntry class will belong to the core Maven module, whereas the ColumnAdditionOperation class will be part of the module that implements all our standard operations, so to put the tests in the corresponding modules we need to remove the dependency from HistoryEntryTests to ColumnAdditionOperation.

@wetneb wetneb requested a review from tfmorris April 28, 2024 10:20
@tfmorris tfmorris merged commit a03ee58 into OpenRefine:master May 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants