Invalid desktop file (missing icon)

[stanislav-brabec]

Problem Description

src/tools/org.opensc.notify.desktop.in uses Icon=preferences-system-notifications without installing any icon. It is acceptable only for icons that are included in the Icon Naming Specification[1], section Application. preferences-system-notifications is not there. It exists only in GNOME specific themes. But org.opensc.notify.desktop.in does not contain OnlyShowIn=GNOME.

References:
[1] https://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

Proposed Resolution

Use an icon defined in the Icon Naming Specification, e. g. preferences-other
or
Install custom icon (or embed GNOME icon to the package).

Additionally, it is recommended to add GenericName, e. g.
`GenericName=Smart card notification

Steps to reproduce

Use other desktop environment than GNOME.
Application has no icon.

Logs

N/A

[frankmorgner]

GenericName is not required nor do I see a recommendation for it anywhere...

[stanislav-brabec]

GenericName is not required, but it is recommended. Many desktop systems display that GenericName together with the Name. It makes life easier to people who don't know names of applications. (Yes, Comment contains details as well, but it is typically displayed only as a pop-up.)