Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardOS 5.0 support improvement #1079

Closed
wants to merge 1 commit into from
Closed

Conversation

debrouxl
Copy link

I saw that OpenSC 0.17-rc1 became available in Debian sid, so I attempted to test it against my CardOS 5.0 card. I noticed that pkcs11-tool -t -l failed the same way it did in April before I applied the relevant part of an additional change by @Jakuje on top of #1003 .

If this gets into the 0.17 release, I can quit using my own patched builds of OpenSC :)
The fact that the 0.17 release is close is why I made a minimal change to use P1 = 0x41 selectively on CardOS 5.0, instead of the more invasive code simplification (unifying CardOS 5.0 and 5.3 support) from Jakuje@7356ee7 .

See the comments of OpenSC#1003 for more information.
@frankmorgner
Copy link
Member

@Jakuje does this patch fix your problems you had with testing the release?

@Jakuje
Copy link
Member

Jakuje commented Jun 26, 2017

Frank, I don't think so.
I have only 5.3 cards (which do not work now) and this PR changes the behavior of 5.0 cards. Though I am wondering why that referenced branch was not brought in (probably I forgot to finish the PR).
I would be for merging rather the referenced branch, since it is removing the 5.3 complexity which I introduced before knowing the 5.0 and 5.3 are the same for the supported use cases so far.

@Jakuje
Copy link
Member

Jakuje commented Jun 26, 2017

@debrouxl Testing #1080 with CardOS 5.0 to make sure it solves the problem and does not break anything else there would be appreciated. I put together simple commands to do that since here we can not use pkcs11-tool:

https://gist.github.com/Jakuje/5a993d2b2d8a9cac35203599e49e6831

mouse07410 pushed a commit to mouse07410/OpenSC that referenced this pull request Jul 6, 2017
…ures (OpenSC#1080)

* Simplify CardOS 5.0 support (removing explicit 5.3 marker since the behavior should be the same)

* Restore RSA_PKCS signatures functionality

Closes OpenSC#1079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants