fixed warnings and some bugs #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 25, 2013 04:22
fixes a lot of warnings which pass a const buffer to the APDU's data Note that a non-const data member is only required for sc_allocate_apdu sc_free_apdu. They are currently used with an explicit typecast. However, sc_allocate_apdu and sc_free_apdu both are not used once in the entire project. One might also simply throw both functions away.
The structures PIN_MODIFY_STRUCTURE and PIN_VERIFY_STRUCTURE now use a C99 flexible array member when available for abData field. uint8_t abData[]; See http://lists.alioth.debian.org/pipermail/pcsclite-cvs-commit/2013-May/006191.html
|
Can one of the admins verify this patch? |
|
@JenkinsForOpenSC ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still some warnings to go...