Remove reselection of DF after error in decipher, sign and derive #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmorgner
approved these changes
Mar 13, 2024
|
I tried to test this with several cards we have, but unfortunately, none hit the reselection case. |
Jakuje
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3044
After the error in
sc_pkcs15_decipher/sc_pkcs15_derive/sc_pkcs15_derive, the DF is reselected and the operation is called for second time. This is problematic for cards which require authentication before operations with private key.The code for reselecting the DF and second call for operations is removed, based on discussion in #3044.
Checklist