Changes to properly identify IDPrime MD 840 #3146
Merged
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously MD 840 was identified as 940. Also changed the part where mechanism are assigned to the card, so that EC is also added as by spec.
|
Thank you for the PR. I will run some tests on the cards I have tomorrow. |
|
Did you change code style lately? I followed the file.... It wants different indents. |
|
No, the clang-format does not capture all the corner cases. Feel free to ignore the proposa of changes to the array of structs. The long condition should be wrapped but the line needs to end with the logical operator, not start with it and the continuation should be 2 tabs. |
Jakuje
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously MD 840 was identified as 940.
Also changed the part where mechanism are assigned to the card, so that EC is also added as by spec.
Fixes #3106