Minor code quality improvements to fix in relation to #412 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UNICODE is set by default by Visual Studio (but can be deactived) The trick is to force ANSI version by appending a A to the function calls.
…_NUMBER) Fix the WCHAR / CHAR conversion problem in CardAuthenticateEx in case of PinPAD (vs->wzPinContext is UNICODE) Fix UNICODE compilation problem( MessageBoxA instead of MessageBox)
Basically checks that the memory allocation succeed. The ctbcs.c change improve the readability because count = 0 and len > 254 does not add any value.
Conflicts: src/minidriver/minidriver.c
|
The Travis compilation failed like yesterday (without a compilation error). I'll wait a few hours and do a commit to force a recompilation as suggested by Frank. |
|
looks good, thank you. |
|
I'm waiting for a second opinion, especially on the conflict resolution for the minidriver (which I can't test). |
|
See @viktorTarasov comments on #426 |
|
MD changes shortly tested (certutil, generate key, import cert, authentication in IE) on Vista 32 bit. Applied in 8ea328f, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As requested here my contribution to fix a few code analysis warnings.
Indeed, it is difficult to test it but the modifications are minor and they may be checked using a code review.
regards,
Vincent LE TOUX