iso7816.c: allow file length stored in more than 2 bytes #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in iso7816-4 chapter 7.4.3 table 10
|
Could you check if |
|
@frankmorgner sc_asn1_decode_integer seems to be better. I'll upgrade my patch. |
|
|
…n1_decode_integer
|
@frankmorgner : done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in chapter 7.4.3 of iso 7816-4, file length, encoded in tag 0x80 or 0x81 can be stored in more than 2 bytes.
As is, the code allows only 2 bytes and check only for the first tag. If there is 2 tags with 4 bytes then 2 bytes, the file size computation fails.
https://github.com/OpenSC/OpenSC/blob/master/src/libopensc/iso7816.c#L362-373
This patch push the limit to 4 bytes and moreover, if one tag has an incorrect value, it tries the next tag.