Add warning category #129
Merged
Add warning category #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Honny1
force-pushed
the
add-warning-category
branch
3 times, most recently
from
eec0d86
to
bbdb8b6
Compare
jan-cerny
reviewed
Feb 13, 2023
| @@ -178,7 +178,10 @@ | |||
| <i class="fas fa-fw fa-exclamation-triangle" aria-hidden="true"></i> | |||
| </div> | |||
| <div class="pf-c-alert__title"> | |||
| {{- warning | set_css_for_list -}} | |||
| Warning category: {{- warning.category | capitalize -}} | |||
There was a problem hiding this comment.
This looks ugly. Keep only Warning as a title. Put the category value to a box or under the heading and don't use the "category" word at all.
There was a problem hiding this comment.
What about using the <category> warning format? As it is in the picture.
Honny1
force-pushed
the
add-warning-category
branch
from
bbdb8b6
to
bb94541
Compare
jan-cerny
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning data class that contains the category and text of the warning.