JSON content extension #130
Conversation
Honny1
force-pushed
the
expand-json-content
branch
from
ed2eacf
to
12923d4
Compare
Honny1
force-pushed
the
expand-json-content
branch
3 times, most recently
from
5b6b888
to
38a6cc4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Honny1
force-pushed
the
expand-json-content
branch
3 times, most recently
from
504fe54
to
8cfcbe6
Compare
Honny1
force-pushed
the
expand-json-content
branch
2 times, most recently
from
15ad63a
to
9018a6d
Compare
| def test_json_count_of_rules(): | ||
| report = get_report() | ||
| json_dict = report.as_dict_for_default_json() | ||
| assert len(json_dict["rules"]) == 714 |
There was a problem hiding this comment.
Do you think that it's the best idea to have a test file that contains 714 rules?
There was a problem hiding this comment.
I think it's okay. This test is labelled as an integration test. So it can be excluded from the normal test run using pytest -m "not integration_test" to reduce testing time. I think this test should check more than just the number of rules, but if I get too specific, the test will break after changing the JSON schema.
| if rule_id in ids_of_selected_rules: | ||
| selected_rules[rule_id] = rule | ||
| elif rule["result"] != "notselected" and not is_not_empty(ids_of_selected_rules): | ||
| selected_rules[rule_id] = rule |
There was a problem hiding this comment.
both branches do the same, please consolidate
Honny1
force-pushed
the
expand-json-content
branch
from
9018a6d
to
974fdea
Compare
|
Changes:
|
Honny1
force-pushed
the
expand-json-content
branch
from
974fdea
to
6a0e9b6
Compare
tests/json_schema_of_report.json
Outdated
| "scan_result", | ||
| "rules" | ||
| ] | ||
| } |
| def test_rearrange_identifiers(dictionary_json, result): | ||
| rearrange_identifiers(dictionary_json) | ||
| print(dictionary_json) | ||
| print("aaaa") |
| @pytest.mark.parametrize( | ||
| "dictionary, result", | ||
| [ | ||
| ({"a": "", "b": {"c": ""}, "x": "x"}, {"x": "x"}), |
There was a problem hiding this comment.
You're testing the same "b": {"c": ""} 5 times. It does not bring any more security but drastically reduces test readability. Make sure that your cases are as unique as possible.
| rearrange_identifiers(dictionary_json) | ||
| print(dictionary_json) | ||
| print("aaaa") | ||
| print(result) |
Honny1
force-pushed
the
expand-json-content
branch
from
6a0e9b6
to
a286865
Compare
This PR expands JSON content. It also adds:
It depends on #129