Add multi-check rules #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honny1
force-pushed
the
multi-check-rules
branch
2 times, most recently
from
4c2e208
to
f1053be
Compare
Honny1
force-pushed
the
multi-check-rules
branch
from
f1053be
to
ec5e8a4
Compare
evgenyz
requested changes
Apr 11, 2023
| return self.reports_with_oval_definitions[self.cpe_source] | ||
| logging.warning(( | ||
| "The given input does not contain a clear mapping of the OVAL definition used" | ||
| " for CPE checks. The results of the OVAL definition in the CPE checks could " |
There was a problem hiding this comment.
Spaces: at the end or at the start?
| @@ -107,4 +107,11 @@ def parse_report(self): | |||
| self._debug_show_rules(rules) | |||
| report.rules = rules | |||
| report.groups = groups | |||
|
|
|||
| if len(report.profile_info.selected_rules_ids) > 0: | |||
| report.profile_info.selected_rules_ids.extend(rule_parser.to_select_rule_ids) | |||
There was a problem hiding this comment.
That should be a ProfileInfo mutate method, like extend_selected_rules_ids. Along with the logic how/when to do that if len(report.profile_info.selected_rules_ids) > 0:.
Why do you update it only when it is not empty by the way?
There was a problem hiding this comment.
There are two approaches how to determine if the rule is selected.
- First is to get information from elements
<xccdf-1.2:select ...>. A list ofselected_rules_idsrepresents these elements. - The second is to get information from the result of the rule.
The second approach is used if select elements aren't present in the ARF report. That is why the list is not extended when the list is empty.
…ysis system and specify which OVAL result report is for CPE
…nd rename the method to get_list_of_cpe_platforms_that_satisfy_evaluation_target
Honny1
force-pushed
the
multi-check-rules
branch
from
ec5e8a4
to
3edc61b
Compare
Honny1
force-pushed
the
multi-check-rules
branch
from
3edc61b
to
208db6c
Compare
|
Changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multi-check rules to the HTML report.
Example:
Depend on: #140