Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the calculation of the score #200

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Explain the calculation of the score #200

merged 3 commits into from
Jul 18, 2023

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Jul 3, 2023

This PR adds a tooltip that explains the computation of the score in the report.

Fixes: #163

@Honny1 Honny1 changed the title Explain score Explain score computation Jul 4, 2023
@Honny1 Honny1 marked this pull request as ready for review July 4, 2023 16:22
@Honny1 Honny1 changed the title Explain score computation Explain the calculation of the score Jul 4, 2023
@jan-cerny jan-cerny self-assigned this Jul 18, 2023
jan-cerny
jan-cerny approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have generated a HTML report with your patch and I have seen the score explanation is displayed successfully when hovering the mouse.

@jan-cerny jan-cerny merged commit d3c2903 into OpenSCAP:main Jul 18, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain the calculation of the scan score
2 participants
@Honny1 @jan-cerny