Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ketika menghapus surat di Arsip Layanan Surat #943

Closed
MUHAMMADRANGSEL opened this issue Apr 21, 2018 · 4 comments
Closed

Bug: ketika menghapus surat di Arsip Layanan Surat #943

MUHAMMADRANGSEL opened this issue Apr 21, 2018 · 4 comments
Assignees
Labels

Comments

@MUHAMMADRANGSEL
Copy link

Bug ketika menghapus surat di Arsip Layanan Surat, keluar peringatan error data gagal disimpan dan tampilannya seperti gambar dibawah ini :
screenshot 2018-04-21 22 58 34

@egodasa
Copy link
Contributor

egodasa commented Apr 22, 2018

Tapi datanya masih tetap kehapus bukan? Hanya muncul pesan error yang gk sesuai, yang seharusnya data berhasil dihapus, tetapi malah pesan gagal disimpan

@eddieridwan eddieridwan changed the title Bug ketika menghapus surat di Arsip Layanan Surat Bug: ketika menghapus surat di Arsip Layanan Surat Apr 22, 2018
@eddieridwan eddieridwan self-assigned this Apr 22, 2018
@eddieridwan
Copy link
Collaborator

Masalah ini disebabkan cara kerja $this->db->error() yang berbeda di CI v3.x.

Solusinya, ubah semua penggunaan kalimat itu.

Sdh dicommit ke master.

@egodasa
Copy link
Contributor

egodasa commented Apr 22, 2018

Maaf Mas @eddieridwan , menurut dokumentasi cara pengecekan errornya adalah if(!$this->db->where('id', $id)->delete('log_surat')) { $_SESSION['success'] = -1; }

@eddieridwan
Copy link
Collaborator

eddieridwan commented Apr 22, 2018

@egodasa, terima kasih. Ya lebih baik begitu. Dan penambahan pesan errornya juga salah: $_SESSION['error_msg'] = $this->db->error->message(); seharusnya $_SESSION['error_msg'] = $this->db->error()['message'].

Ok, silakan kerjakan, dan kirim pull request. Ikuti panduan https://github.com/OpenSID/OpenSID/wiki/Cara-Ikut-Mengembangkan-OpenSID dan https://github.com/OpenSID/OpenSID/wiki/Panduan-mengirimkan-perubahan-repo-OpenSID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants