Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backdoor User Setting #920

Merged
merged 2 commits into from
Apr 8, 2018
Merged

Backdoor User Setting #920

merged 2 commits into from
Apr 8, 2018

Conversation

esyede
Copy link
Contributor

@esyede esyede commented Apr 7, 2018

Fix #899

@esyede esyede changed the title Backdor User Setting Backdoor User Setting Apr 7, 2018
@eddieridwan eddieridwan merged commit 8834929 into OpenSID:master Apr 8, 2018
@eddieridwan
Copy link
Collaborator

eddieridwan commented Apr 8, 2018 •
edited
Loading

Sdh digabung ke master. Tetapi akan dibuat issue tambahan untuk:

  1. di versi sebelumnya, ukuran image sengaja dibuat kecil, karena memang hanya diperlukan image kecil -- supaya lebih ringan uploadnya. Pengecilan itu perlu dikembalikan. Berkas foto pengguna perlu diperkecil #923
  2. perlu ditambahkan suffix acak pada nama berkas yg diunggah, supaya nama berkas tidak bisa ditebak, misalnya desa/upload/user_pict/kecil_kitten.jpg. Security: Tambahkan suffix acak pada nama berkas foto pengguna #924
  3. pesan error perlu dirinci, misalnya jenis berkas salah --- sekarang hanya pesan gagal saja. Pesan error pada waktu menggungah foto pengguna perlu dirinci #925

@eddieridwan eddieridwan mentioned this pull request Apr 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esyede @eddieridwan