mid_registrar: fix possible crash for REGISTER messages without contact

Fixes Coverity CID #163986
OpenSIPS · Mar 9, 2017 · 8f5572b · 8f5572b
1 parent fda5484
commit 8f5572b
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/modules/mid_registrar/save.c b/modules/mid_registrar/save.c
@@ -2236,11 +2236,9 @@ int mid_reg_save(struct sip_msg *msg, char *dom, char *flags_gp,
 	}
 
 	if (get_first_contact(msg) == NULL) {
-		if (st) {
+		if (st)
 			sctx.star = 1;
-			return prepare_forward(msg, ud, &sctx.aor, &sctx);
-		}
-		goto quick_reply;
+		return prepare_forward(msg, ud, &sctx.aor, &sctx);
 	}
 
 	/* in mirror mode, all REGISTER requests simply pass through */
@@ -2265,7 +2263,6 @@ int mid_reg_save(struct sip_msg *msg, char *dom, char *flags_gp,
 	else if (rc == 1)
 		goto out_forward;
 
-quick_reply:
 	/* forwarding not needed! This REGISTER will be absorbed */
 
 	/* prepare the Contact header field for a quick 200 OK response */