-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We now rely on libxml api instead of cut/paste. #18
Conversation
@@ -53,6 +53,7 @@ | |||
#include "../../pt.h" | |||
#include "../../mi/mi.h" | |||
#include "../pua/hash.h" | |||
#include "../pua/pidf.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you include pidf.h here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To rely on libxml api. IMHO, it should not be defined in pua/ though; but that's a different problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it could be moved to presence/lxml_utils.h ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. But iirc several other modules are already relying on pidf.h being in pua/
That would be another patch than this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'd rather have the issue fixed all the way rather than having half of it fixed... we can leave this open until then, no problem.
Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days. |
Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details. |
If accepted, please credit Damien Sandras from Be IP s.a. @ http://www.beip.be