This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
getaddrinfo_async: Check return value of getservbyname_r earlier #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If getservbyname_r fails (or HAVE_GETSERVBYNAME_R_4_ARGS is not defined) it doesn't make any sense to access member of the servent struct as it will not be initialized then. Calling endservent_r shouldn't be necessary either then. GCC 8 also complains about this code part when compiling with the -Wmaybe-uninitialized flag.
|
I agree that accessing the servent struct unconditionnaly is not nice but I would still call endservent_r(). |
Looks good to me. |
|
The relevant changes have been commited |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
getservbyname_rfails (orHAVE_GETSERVBYNAME_R_4_ARGSis not defined)it doesn't make any sense to access member of the
servent structas itwill not be initialized then. Calling
endservent_rshouldn't benecessary either then.
GCC 8 also complains about this code part when compiling with
the
-Wmaybe-uninitializedflag.