Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding section Acknowledges #41

Merged
merged 22 commits into from
May 3, 2023
Merged

Adding section Acknowledges #41

merged 22 commits into from
May 3, 2023

Conversation

YurelyCamacho
Copy link
Contributor

@YurelyCamacho YurelyCamacho commented Apr 24, 2023 •
edited
Loading

Add acknowledges page to website and psf logo on this page

By @Anavelyz and @YurelyCamacho
@EverVino @xmnlab

xmnlab
xmnlab requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En terminos de estructura, solo mencioné sobre la identación en los metadatos.

A parte de eso, sería cool dar más detalles sobre el grant, para qué proyecto, qué sw va a realizar con este monto (algo muy resumido)

Gracias por trabajar en esto

content/acknowledges/index-en.md Show resolved Hide resolved
content/acknowledges/index-es.md Outdated Show resolved Hide resolved
@EverVino
Copy link
Contributor

Gracias @YurelyCamacho todo parece estar bien.

@EverVino
Copy link
Contributor

EverVino commented Apr 30, 2023 •
edited
Loading

@YurelyCamacho Al parecer la rama esta un poco desactualizada. Podrías hacer un rebase
Aquí un tutorial para hacer el rebase
https://johnnycase.github.io/post/2021/07/28/git-rebase-fork.html
en vez de url pon la url de este repositorio

@xmnlab
Copy link
Member

xmnlab commented Apr 30, 2023

Btw, para los próximos PR por favor abrir tu PR desde un fork :) gracias

@YurelyCamacho YurelyCamacho requested a review from xmnlab May 1, 2023 18:47
xmnlab
xmnlab reviewed May 2, 2023
View reviewed changes
content/blog/la-investigacion-abierta-el-manejo-de-repositorios-y-control-de-versiones/index.md Outdated
@@ -3,8 +3,13 @@ title: "La investigación abierta, el manejo de repositorios y control de versio
slug: la-investigacion-abierta-el-manejo-de-repositorios-y-control-de-versiones
date: 2020-02-28
author: Anavelyz Perez
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you included git diffs inside the code. please fix that.

xmnlab
xmnlab reviewed May 2, 2023
View reviewed changes
.../te-mostramos-cinco-librerias-en-python-para-tu-proximo-proyecto-de-ciencia-abierta/index.md Outdated
@@ -3,8 +3,13 @@ title: "Te mostramos cinco librerías en Python para tu próximo proyecto de cie
slug: te-mostramos-cinco-librerias-en-python-para-tu-proximo-proyecto-de-ciencia-abierta
date: 2020-06-09
author: Anavelyz Perez
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you included git diffs inside the code. please fix that.

xmnlab
xmnlab requested changes May 2, 2023
View reviewed changes
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YurelyCamacho thanks for working on that.
it seems you included git diffs inside the code
please, fix that and ping me when it is ready again for another round of review

@YurelyCamacho YurelyCamacho requested a review from xmnlab May 3, 2023 01:21
xmnlab
xmnlab approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for working on that @YurelyCamacho

@xmnlab xmnlab merged commit 71fe747 into OpenScienceLabs:main May 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YurelyCamacho @EverVino @xmnlab @luabida @Anavelyz