Enable building with a libopenshot-audio that's based on non-bundled JUCE #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdnyc
added
the
build
ferdnyc
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #515 +/- ##
========================================
Coverage 48.23% 48.23%
========================================
Files 128 128
Lines 9950 9949 -1
========================================
Hits 4799 4799
+ Misses 5151 5150 -1
Continue to review full report at Codecov.
|
|
Merging this, as it's fine with the current libopenshot-audio source, but the build will start breaking if OpenShot/libopenshot-audio#97 is merged before it. |
This was referenced May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR to OpenShot/libopenshot-audio#97, and contains the fixes necessary in libopenshot's build to ensure that it works with a libopenshot-audio that wasn't built from our bundled JUCE sources.
(See that PR, as well as Debian bug 925755, for background.)
In addition:
juce::prefixing, in places the unit tests don't touch (so it's not technically critical)juce::ScopedPointer(which is deprecated) with the recommendedstd::unique_ptrreplacement.