Fix support for older CMake #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_compile_definitions() is CMake 3.12+ only.
ferdnyc
added
the
build
Codecov Report
@@ Coverage Diff @@
## develop #516 +/- ##
========================================
Coverage 48.23% 48.23%
========================================
Files 128 128
Lines 9949 9949
========================================
Hits 4799 4799
Misses 5150 5150 Continue to review full report at Codecov.
|
|
Travis seems to be permanently out to lunch here, I think perhaps because I submitted this PR using the same branch as the one I'd just merged. Closing and trying with a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
add_compile_definitions()in #515, which is CMake 3.12+ only. (Oops.) Switch toadd_definitions()which has been supported since the dawn of time.