Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an issue caused by timeline::GetClip returning a ClipBase* instead of Clip* #595

Merged
merged 1 commit into from Dec 3, 2020

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Dec 3, 2020

Fixing an issue caused by timeline::GetClip returning a ClipBase instead of a Clip (broke waveform generation).
Also adding a swig definition for the Caption effect.

…ead of a Clip (broke waveform generation).

Also adding a swig definition for the Caption effect.
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #595 (ac73bd9) into develop (9a91abc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #595   +/-   ##
========================================
  Coverage    52.54%   52.54%           
========================================
  Files          129      129           
  Lines        10707    10707           
========================================
  Hits          5626     5626           
  Misses        5081     5081           
Impacted Files Coverage Δ
src/Timeline.h 63.63% <ø> (ø)
src/Timeline.cpp 45.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a91abc...ac73bd9. Read the comment docs.

@jonoomph jonoomph merged commit e6eef0d into develop Dec 3, 2020
@jonoomph jonoomph deleted the fix-get-clip-method branch December 3, 2020 18:51
@ferdnyc
Copy link
Contributor

ferdnyc commented Dec 4, 2020

@jonoomph Gah! Should've realized I was accidentally slicing the Clip object there, thanks for fixing that up.

GetClipEffect() similarly returns EffectBase*, but I suppose there's no helping that. But by the same token, it shouldn't be a problem because the common API all lives there.

@ferdnyc
Copy link
Contributor

ferdnyc commented Dec 4, 2020

I'm surprised the unit tests didn't need changing, I guess I must've used auto for the types. Go me?

Though, a unit test that tries to access the Clip API of the returned object (such as Clip::Waveform) would've caught this, and would probably be a good thing to add to Clip_Tests.cpp Timeline_Tests.cpp.

@ferdnyc
Copy link
Contributor

ferdnyc commented Dec 4, 2020

Defense Against the Dark Slice invocations added to the Timeline unit tests, in #596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants