Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline::GetClip: Add anti-slicing checks to unit tests #596

Merged
merged 1 commit into from Dec 4, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Dec 4, 2020

Defense against any recurrence of #595 breakage.

@ferdnyc ferdnyc added the tests Changes related to the unit tests and/or code coverage label Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #596 (5e2c2bc) into develop (e6eef0d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #596      +/-   ##
===========================================
+ Coverage    52.54%   52.56%   +0.02%     
===========================================
  Files          129      129              
  Lines        10707    10710       +3     
===========================================
+ Hits          5626     5630       +4     
+ Misses        5081     5080       -1     
Impacted Files Coverage Δ
tests/Timeline_Tests.cpp 100.00% <100.00%> (ø)
src/Clip.h 83.33% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6eef0d...5e2c2bc. Read the comment docs.

@ferdnyc ferdnyc merged commit e8b4dde into OpenShot:develop Dec 4, 2020
@ferdnyc ferdnyc deleted the lookup-api-tests branch December 4, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Changes related to the unit tests and/or code coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant