Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor due to profiling improvements (in libopenshot) #4012

Merged
merged 5 commits into from Feb 25, 2021

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Feb 18, 2021

Related to profiling and performance improvements in libopenshot: OpenShot/libopenshot#638

Improvements to openshot-qt:

  • I've removed some unused settings, related to OpenMP
  • Updated effect icons & cache icons
  • Updated translation templates
  • Fixed a regression causing the Caption dock to appear when upgrading OpenShot

@jonoomph jonoomph changed the title Huge performance improvements (43% faster FFmpegReader, 34% faster Timeline) Refactor due to profiling improvements (in libopenshot) Feb 18, 2021
@jonoomph
Copy link
Member Author

@ferdnyc Hiya! Do you know why this keeps failing? I haven't really dug into yet, just curious: https://github.com/OpenShot/openshot-qt/pull/4012/checks?check_run_id=1931336145

@ferdnyc
Copy link
Contributor

ferdnyc commented Feb 19, 2021

@jonoomph Yeah, that's what I was trying to sort out with #3938. Basically, setting up the QtWebEngine just to run the unit tests is... problematic, as it's not being shut down properly. After struggling with it for a while and getting nowhere, I eventually decided that we shouldn't really NEED the Timeline web interface for the unit tests, at all, so I was trying to come up with a workable way to use a "dummy" Timeline backend with just enough functionality to let the unit tests execute, and without actually loading any browser components.

IIRC I didn't get all the way there with it, at least not yet. Haven't looked at it in like a month, though.

In theory this could also be solved by making sure the web backend is properly and completely spun up and
then shut down again before the unit test run terminates. Problem is, it doesn't seem like the WebEngine actually starts loading until the interface is shown, which we don't actually do, and then can't be shut down until it's fully loaded. Which just to run the unit tests would take forever. (Like potentially ~20 seconds.)

Oh, right, and the xvfb environment doesn't support OpenGL (obviously), which is also problematic for QtWebEngine.

@jonoomph jonoomph merged commit 4020642 into develop Feb 25, 2021
@jonoomph jonoomph deleted the profiling-improvements branch February 25, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants