Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor due to profiling improvements (in libopenshot) #4012

Merged
merged 5 commits into from
Feb 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file modified src/effects/icons/bars.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/blur.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/brightness.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/caption.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/chromakey.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/colorshift.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/crop.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/deinterlace.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/hue.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/mask.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/negate.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/objectdetector.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/pixelate.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/saturation.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/shift.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/stabilizer.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/tracker.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/effects/icons/wave.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/images/cache/NewWebsite.png
Binary file not shown.
Binary file modified src/images/cache/bars.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/images/cache/blur.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/images/cache/brightness.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/images/cache/caption.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/images/cache/chromakey.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/images/cache/colorshift.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/images/cache/crop.png
Binary file modified src/images/cache/deinterlace.png
Binary file modified src/images/cache/hue.png
Binary file modified src/images/cache/mask.png
Binary file modified src/images/cache/negate.png
Binary file modified src/images/cache/objectdetector.png
Binary file modified src/images/cache/pixelate.png
Binary file modified src/images/cache/saturation.png
Binary file modified src/images/cache/shift.png
Binary file modified src/images/cache/stabilizer.png
Binary file modified src/images/cache/tracker.png
Binary file modified src/images/cache/wave.png
2,710 changes: 1,413 additions & 1,297 deletions src/language/OpenShot/OpenShot.pot

Large diffs are not rendered by default.

452 changes: 226 additions & 226 deletions src/language/OpenShot/OpenShot_blender.pot

Large diffs are not rendered by default.

1,916 changes: 958 additions & 958 deletions src/language/OpenShot/OpenShot_emojis.pot

Large diffs are not rendered by default.

632 changes: 316 additions & 316 deletions src/language/OpenShot/OpenShot_transitions.pot

Large diffs are not rendered by default.

8 changes: 0 additions & 8 deletions src/settings/_default.settings
Original file line number Diff line number Diff line change
Expand Up @@ -422,14 +422,6 @@
"values": [],
"restart": true
},
{
"value": true,
"title": "Process Video Frames in Parallel (Experimental)",
"type": "bool",
"restart": false,
"category": "Performance",
"setting": "omp_threads_enabled"
},
{
"min": 0,
"max": 128,
Expand Down
17 changes: 1 addition & 16 deletions src/windows/export.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class Export(QDialog):

ExportStarted = pyqtSignal(str, int, int)
ExportFrame = pyqtSignal(str, int, int, int, str)
ExportEnded = pyqtSignal(str)
ExportEnded = pyqtSignal(str)

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
Expand Down Expand Up @@ -111,7 +111,6 @@ def __init__(self, *args, **kwargs):
self.txtChannels.setVisible(False)

# Set OMP thread disabled flag (for stability)
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True
openshot.Settings.Instance().HIGH_QUALITY_SCALING = True

project_timeline = get_app().window.timeline_sync.timeline
Expand Down Expand Up @@ -1012,12 +1011,6 @@ def titlestring(sec, fps, mess):
# Clear all cache
self.timeline.ClearAllCache()

# Re-set OMP thread enabled flag
if self.s.get("omp_threads_enabled"):
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = False
else:
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True

# Return scale mode to lower quality scaling (for faster previews)
openshot.Settings.Instance().HIGH_QUALITY_SCALING = False

Expand Down Expand Up @@ -1066,14 +1059,6 @@ def reject(self):
# Resume export
return

# Re-set OMP thread enabled flag
# NOTE: This is always called when closing the export modal, and thus
# the keyframes are always scaled back to the original FPS if needed.
if self.s.get("omp_threads_enabled"):
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = False
else:
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True

# Return scale mode to lower quality scaling (for faster previews)
openshot.Settings.Instance().HIGH_QUALITY_SCALING = False

Expand Down
6 changes: 0 additions & 6 deletions src/windows/main_window.py
Original file line number Diff line number Diff line change
Expand Up @@ -2927,12 +2927,6 @@ def __init__(self, *args, mode=None):
else:
openshot.Settings.Instance().PLAYBACK_AUDIO_DEVICE_NAME = ""

# Set OMP thread enabled flag (for stability)
if s.get("omp_threads_enabled"):
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = False
else:
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True

# Set scaling mode to lower quality scaling (for faster previews)
openshot.Settings.Instance().HIGH_QUALITY_SCALING = False

Expand Down
8 changes: 0 additions & 8 deletions src/windows/preferences.py
Original file line number Diff line number Diff line change
Expand Up @@ -485,14 +485,6 @@ def bool_value_changed(self, widget, param, state):
# Stop autosave timer
get_app().window.auto_save_timer.stop()

elif param["setting"] == "omp_threads_enabled":
if (state == Qt.Checked):
# Enable OMP multi-threading
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = False
else:
# Disable OMP multi-threading
openshot.Settings.Instance().WAIT_FOR_VIDEO_PROCESSING_TASK = True

# Check for restart
self.check_for_restart(param)

Expand Down
3 changes: 3 additions & 0 deletions src/windows/ui/main-window.ui
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,9 @@
<attribute name="dockWidgetArea">
<number>4</number>
</attribute>
<property name="visible">
<bool>false</bool>
</property>
<widget class="QWidget" name="dockWidgetContentsCaption">
<layout class="QGridLayout" name="gridLayoutCaption">
<property name="leftMargin">
Expand Down