Update build workflow for modular protobuf version support #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pmai
commented
Jan 12, 2024
pmai
commented
- Make protobuf version easily configurable
- Add support for protobuf versions 22.0 and up
- Update workflow actions to newest versions
pmai
force-pushed
the
build/refactor-dependency-setup
branch
from
888762e
to
1fc305c
Compare
|
#756 does conflict now with this one. Do you want to have a look at my PR, compare and afterwards we close mine? |
I'd suggest to recenter #756 around the python changes (e.g. by rebasing against this one and dropping the unrelated workflow changes), so that the python stuff can be handled separately. If you want, I can make those changes in the other PR. I'll also create a separate one for the release workflow changes, as these need to be reviewed by ASAM Office, who are more knowledgeable about any impacts. |
|
CCB 2024-01-15: Merge as-is |
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai
force-pushed
the
build/refactor-dependency-setup
branch
from
1fc305c
to
56faac7
Compare
pmai
added
the
ReadyToMerge
|
Reviewed for v3.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.