Add more top-level messages to OSITrace #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
jdsika
approved these changes
May 28, 2024
jdsika
added
the
Bug
|
To be honest I think this is more a bug then a feature request and I would merge this for 3.7.0 But this should be discussed by @pmai and @PhRosenberger |
jdsika
added
the
ReadyForCCBReview
6 tasks
Add all remaining top-level interfaces, fix documentation list of said interfaces and add tests for all interfaces to the osi_trace tests. Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
PhRosenberger
approved these changes
Jun 10, 2024
florianwallerer
approved these changes
Jun 10, 2024
pmai
added
ReadyToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
#817
Add a description
Added "TrafficUpdate", "TrafficCommand" and "TrafficCommandUpdate" as possible type inputs.
I tested locally with osi2read.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: