Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider configuration from the configuration center #98

Closed
beckjin opened this issue Oct 27, 2018 · 8 comments
Closed

Please consider configuration from the configuration center #98

beckjin opened this issue Oct 27, 2018 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@beckjin
Copy link
Contributor

beckjin commented Oct 27, 2018

default

It is possible that configuration is not through appsettings.json, but through configuration center.

@liuhaoyang
Copy link
Collaborator

If you need to load the configuration from the config center, you can implement a custom IConfigAccessor (such as ConfigCenterAccessor) and register it to the DI.

@beckjin
Copy link
Contributor Author

beckjin commented Oct 29, 2018

You're right, thank you.

@liuhaoyang liuhaoyang reopened this Feb 13, 2019
@liuhaoyang liuhaoyang added this to the 0.9.0 milestone Feb 13, 2019
@liuhaoyang liuhaoyang added the enhancement New feature or request label Feb 13, 2019
@liuhaoyang liuhaoyang self-assigned this Feb 13, 2019
@liuhaoyang
Copy link
Collaborator

Will provide built-in configuration extensions instead of just reimplementing IConfigAccessor

@wu-sheng
Copy link
Member

.net intend to provide this officially?

@liuhaoyang
Copy link
Collaborator

.net intend to provide this officially?

In the micro-service scenario, people prefer to use the config-center to centrally store the application configuration. I think it makes sense to provide the ability to load the agent-config from the config center.

@wu-sheng
Copy link
Member

Which config center do you prefer? I am thinking to provide such feature in java agent too.

@liuhaoyang
Copy link
Collaborator

Which config center do you prefer? I am thinking to provide such feature in java agent too.

My suggestion is that we only provide the interface for third-party configuration loading, and give the specific config-center implementation to the user. How about?

@ElderJames
Copy link
Member

That is, you can implement an IAdditionalConfigurationSource to fit your own configuration source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants