Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments and removed PharoVM guards for windowing support #296

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Added comments and removed PharoVM guards for windowing support #296

merged 1 commit into from
Oct 23, 2018

Conversation

guillep
Copy link
Contributor

@guillep guillep commented Oct 23, 2018

Last integration of #295 went too fast :)

This PR does some cleanups:

  • remove the PharoVM guards,
  • added comments

Answering the questions from the other thread: this should have no effect on systems using a single window. However, with multiple windowing systems, this makes the consumption of events a cooperative task. If let's say SDL does not consume its events (because we don't call the event processing routine), then those events stay in the queue for ever.

To make it more robust I've been trying to use a separate queue to store alien events and repost them in the queue afterwads, but I could not manage to make it work. And Cocoa's support/documentation does not help here...

Copy link
Contributor

@eliotmiranda eliotmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this merged and in use than not being tested. We can fix any breakages later. As long as the simple case works we can then test the more complex cases more easily bu=y having this in the default VM.

@eliotmiranda eliotmiranda merged commit 9320885 into OpenSmalltalk:Cog Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants