Do only handle events that correspond to the VM window #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do remove the guard. This is clearly the right thing to do on any flavour. Thanks for this important fix!! |
|
Do you want to review John since I believe you have good OSX experience? If no one else wants to review I'll merge wednesday afternoon, unless someone has already merged before. Thanks Guille for this fix. Was very annoying. |
|
Ok I will take a look
…Sent from my iPhone
On Oct 22, 2018, at 06:28, Clement Bera ***@***.***> wrote:
Do you want to review John since I believe you have good OSX experience?
If no one else wants to review I'll merge wednesday afternoon.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Ok it looks ok, not sure if it would affect the older multi-window support but I’m not sure anyone used that anyway. |
|
Thanks John. I was scared because last time someone tried to fix this it had side effect on some events in the main window. I merge then. We will see if someone complains. |
|
I've posted #296 removing the PharoVM guard and adding some comments. |
|
BTW Thanks! |
fniephaus
added a commit
that referenced
this pull request
Mar 2, 2020
@guillep introduced some additional logic to filter out events that do not correspond to the VM window. The about panel and the fullscreen frame are also alien windows, but were not receiving any events because of this change. As a consequence, these events will forever remain in the queue and therefore, the buttons of the fullscreen frame and about panel cannot be clicked. This commit reverts all changes back to the previous version that consumes all events and forwards them to NSApp. In order to avoid breaking PharoVM, we do all of this behind an `#ifdef PharoVM`. Relevant changes: #295 #300
tesonep
pushed a commit
to tesonep/opensmalltalk-vm
that referenced
this pull request
Jul 13, 2021
use Sleep on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with SDL on OSX we have noticed that the main window in the VM is randomly eating events that belong to other windows. This happens because we are consuming events regardless the window they come from.
The corresponding code is in the method pumpRunLoopEventSendAndSignal: in
https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/iOS/vm/OSX/sqSqueakOSXApplication%2Bevents.m
I've playing around with making the VM consume only events that come from its own window or from no window (window=null). This seems to work correctly, and I've had run into no issues in the last couple of hours.
I've put a guard so my code is only valid for PHAROVM builds, but I'd gladly remove the guards if people think this is a good move for all the community.