-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropPlugin: Unify numFiles fallback value before DragDrop has been recorded #514
Conversation
Instead, set numFiles= 0 analogously to the Win32 implementation of the plugin.
-----BEGIN PGP SIGNED MESSAGE----- Hello, I've tried building from the "dnd-unify-numfiles" branch. This works for me : I can compile a "squeak-stack-spur" VM from it, However when I try to merge dnd-unify-numfiles into sqUnixXdnd I get So is it please possible that you merge yourself and advise on what change Also is there documentation on the dropFiles changeset on how to use the This would be useful to see how I can test the DemoDropTool. Regards, -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJfP3zkAAoJEAwpOKXMq1MarjkH/1CVvbshbyyiPh5VeLsCEVAs |
Done
Good hint! Just do |
-----BEGIN PGP SIGNED MESSAGE----- Hi, I compiled a new VM from the updated branch: squeak -version5.0-202008211759-dnd-unify-numfiles Sat Aug 22 09:57:02 CEST 2020 cc [Production Spur 64-bit VM]StackInterpreter VMMaker.oscog-eem.2792 uuid: f914b421-12d3-48b8-b510-833495378c66 Aug 22 2020VM: 202008211759-dnd-unify-numfiles stes@gecko:src/thiede/opensmalltalkDate: Fri Aug 21 19:59:53 2020 CommitHash: dae0bf5Plugins: 202008211759-dnd-unify-numfiles stes@gecko:src/thiede/opensmalltalkThen I used the image Squeak6.0alpha-19687-64bit.image. When I drag and drop 2 files myfile1 and myfile2 into the Squeak desktop, If I then (following your previous instructions) browse HandMorph, and when I then drag again the files, it works (without debugger), and 1 So that seems to work. Can you explain more how to use the DemoDropTool ? Regards, -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJfQNVuAAoJEAwpOKXMq1Mal6YIAKVbbsAyJWhW6jZF2MTZ4vCV |
1 similar comment
-----BEGIN PGP SIGNED MESSAGE----- Hi, I compiled a new VM from the updated branch: squeak -version5.0-202008211759-dnd-unify-numfiles Sat Aug 22 09:57:02 CEST 2020 cc [Production Spur 64-bit VM]StackInterpreter VMMaker.oscog-eem.2792 uuid: f914b421-12d3-48b8-b510-833495378c66 Aug 22 2020VM: 202008211759-dnd-unify-numfiles stes@gecko:src/thiede/opensmalltalkDate: Fri Aug 21 19:59:53 2020 CommitHash: dae0bf5Plugins: 202008211759-dnd-unify-numfiles stes@gecko:src/thiede/opensmalltalkThen I used the image Squeak6.0alpha-19687-64bit.image. When I drag and drop 2 files myfile1 and myfile2 into the Squeak desktop, If I then (following your previous instructions) browse HandMorph, and when I then drag again the files, it works (without debugger), and 1 So that seems to work. Can you explain more how to use the DemoDropTool ? Regards, -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJfQNVuAAoJEAwpOKXMq1Mal6YIAKVbbsAyJWhW6jZF2MTZ4vCV |
The ToolBuilder is not a tool but a class that can build tools for you. ToolBuilder open: DemoDropTool. Insert this into any text field and press d to do it. |
-----BEGIN PGP SIGNED MESSAGE----- Hi, This results in a doesNotUnderstand: message for DemoDropTool, Does it work for you ? I get
David Stes -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJfQUCzAAoJEAwpOKXMq1Ma68cH/RmTsvmtMaSpoGXaddKM/Ez9 |
Oh, so sorry, I have no idea how this method has flown off my changeset. :-( If you still have patience, you could try this one: |
-----BEGIN PGP SIGNED MESSAGE----- This new package dropFiles is working: ToolBuilder open:DemoDropTool In any case the VM with dnd-unify-numfiles seems to be working. David Stes -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJfQiYvAAoJEAwpOKXMq1Ma8fkH/2kuQkoWRehBEpttp3/VNM9c |
You can use the DemoDropTool by dragging objects into each of the three panes, and to show that the drop works, it displays each dragged items. For example, try to drag a text to number 5 of the list and the 5 will be replaced by the text. Together with this PR, you can drag a file from the host system directly in this tool. |
@marceltaeumel @nicolas-cellier-aka-nice Friendly reminder that this PR is complete, conflict-free, and ready to merge :-) |
…hod [ postBecomeScanClassTable: ]
…od [ postBecomeScanClassTable: ] KILLED by 1/3 test cases.
… false ] on method [ fetchClassOfNonImm: ] 9 test cases.
…false ] on method [ fetchClassOfNonImm: ] 9/9 test case are EQUIVALENT
Improve entity inspector
This PR aligns the default
numFiles
value recorded forDragEnter
,DragMove
, andDragLeave
events recorded by the X11 implementation of the DropPlugin, which was1
, to the default value used by the Win32 implementation of the plugin, which is0
.The motivation for this change is to unify the event protocol along with different platforms. It would technically be highly expensive and questionable to find out this value before the drop event has been recorded. Concretely, Win32 does not support this at all without switching the library, and on Linux, this would require a performance-extensive ping-pong of "Target to source: Please hand a copy of all dragged files", "Source to target: I converted these files for you", "Target to source: Thank you, but I was only interested into their total number" messages. (However, interestingly macOS appears to support this (I could not yet test it) and https://github.com/codefrau/SqueakJS/ could do so, too.)
While pursuing the same master plan, this PR is not dependent nor reverse-dependent on #508. They can be merged independently of each other.
Please review and merge if you agree. I hereby confirm that I did not observe any regressions when dragging files or folders into a recent Squeak image.