WindowEvent[A|Dea]ctivated
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entDeactivated and record it, too.
|
To whomever it may concern: This is ready for review now! :-) |
eliotmiranda
approved these changes
Nov 10, 2021
|
Thank you Eliot! :-) |
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 25, 2021
… false ] on method [ markAndShouldScan: ]
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 25, 2021
…false ] on method [ markAndShouldScan: ] KILLED by 1/10 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
…oat value ] on method [ allOldSpaceEntitiesForCompactingFrom:to:do: ] 10 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
…at value ] on method [ allOldSpaceEntitiesForCompactingFrom:to:do: ] 3/10 Test Cases are NOT EQUIVALENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the recording of
WindowEventActivatedon all primary platforms (that is, Win32 and Linux; apple does not count unless they provide adequate virtualization support for other platforms). In the past, this event was only declared but never recorded. In addition, the new eventWindowEventDeactivatedis declared and recorded, too.A real application example for this is proposed on the squeak-dev list here, but I do not think that the discussion about this proposal should hinder us from integrating this change into the VM, should it?