-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New example for templates #100
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## new-structure #100 +/- ##
===================================================
+ Coverage 74.11% 100.00% +25.88%
===================================================
Files 3 1 -2
Lines 85 57 -28
===================================================
- Hits 63 57 -6
+ Misses 22 0 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Before this comment, I worked together with Maxie on this PR. From here on I will take over by myself. |
{{cookiecutter.project_slug}}/src/{{cookiecutter.project_slug}}/analysis/predict.py
Outdated
Show resolved
Hide resolved
…Economics/econ-project-templates into new-structure-example
Hope this last commit does not lead to a renewed hell of CI-related issues... Would be very useful if it worked, but there would certainly be ways around it. |
971aea0
to
cbebcbb
Compare
… estimation_table).
cbebcbb
to
54f299f
Compare
At the moment the paper tasks do not run. The problem is that we're using the pytask development version but pytask-latex is not updated yet. I would propose that we skip the latex testing for now, open an issue, and work on it as soon as the new pytask features make it into the next official release. At the moment paper folder is not considered as a 'task'-folder by pytask anyways. |
All good, no need to wait with merging, no rush to release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @timmens,
Congrats -- the new templae examples look really good! I didn't spend time on trying to change any of the code, that looks pretty nice already. I just made a few comments on things that might be a bit confusing for new pytask users and people who see the templates for the first time.
I noticed the task_paper.py
is failing, made a comment but I see now you reported the issue a few days ago.
In this PR we will implement a new example and integrate it into the new structure.
The new example project is structured as follows:
Notes: