Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example for templates #100

Merged
merged 29 commits into from
Apr 13, 2022
Merged

New example for templates #100

merged 29 commits into from
Apr 13, 2022

Conversation

timmens
Copy link
Member

@timmens timmens commented Feb 16, 2022

In this PR we will implement a new example and integrate it into the new structure.


The new example project is structured as follows:

  1. We download data and perform some minor data cleaning steps
  2. We fit a logit model to the data and use the fitted model to predict on new data
  3. We combine the predictions and raw data to create some figures

Notes:

  1. We have to install pytask via github because we need features that are not yet released

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #100 (222805c) into new-structure (492223b) will increase coverage by 25.88%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           new-structure      #100       +/-   ##
===================================================
+ Coverage          74.11%   100.00%   +25.88%     
===================================================
  Files                  3         1        -2     
  Lines                 85        57       -28     
===================================================
- Hits                  63        57        -6     
+ Misses                22         0       -22     
Flag Coverage Δ
end_to_end 100.00% <ø> (+25.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slug}}/src/{{cookiecutter.project_slug}}/config.py
{{cookiecutter.project_slug}}/docs/conf.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492223b...222805c. Read the comment docs.

@timmens timmens changed the base branch from master to new-structure March 4, 2022 10:14
@timmens
Copy link
Member Author

timmens commented Mar 16, 2022

Before this comment, I worked together with Maxie on this PR. From here on I will take over by myself.

@hmgaudecker
Copy link
Member

Hope this last commit does not lead to a renewed hell of CI-related issues... Would be very useful if it worked, but there would certainly be ways around it.

@hmgaudecker hmgaudecker force-pushed the new-structure-example branch 2 times, most recently from 971aea0 to cbebcbb Compare April 5, 2022 07:11
@timmens
Copy link
Member Author

timmens commented Apr 6, 2022

At the moment the paper tasks do not run. The problem is that we're using the pytask development version but pytask-latex is not updated yet.

I would propose that we skip the latex testing for now, open an issue, and work on it as soon as the new pytask features make it into the next official release. At the moment paper folder is not considered as a 'task'-folder by pytask anyways.

@hmgaudecker
Copy link
Member

All good, no need to wait with merging, no rush to release.

Copy link
Member

@carolinalvarez carolinalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @timmens,

Congrats -- the new templae examples look really good! I didn't spend time on trying to change any of the code, that looks pretty nice already. I just made a few comments on things that might be a bit confusing for new pytask users and people who see the templates for the first time.

I noticed the task_paper.py is failing, made a comment but I see now you reported the issue a few days ago.

@timmens timmens merged commit 31f7006 into new-structure Apr 13, 2022
@timmens timmens deleted the new-structure-example branch October 13, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants