Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds to BHHH #376

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Add bounds to BHHH #376

wants to merge 19 commits into from

Conversation

segsell
Copy link
Member

@segsell segsell commented Aug 16, 2022

Add bounds to BHHH algorithm.

To-Do:

  • Implement box constraints
  • Refactor
  • Add more test cases

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #376 (f1626cd) into main (79e8a0e) will increase coverage by 0.05%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   92.88%   92.93%   +0.05%     
==========================================
  Files         223      223              
  Lines       17396    17525     +129     
==========================================
+ Hits        16158    16287     +129     
  Misses       1238     1238              
Impacted Files Coverage Δ
tests/optimization/test_pounders_integration.py 100.00% <ø> (+7.54%) ⬆️
src/estimagic/optimization/bhhh.py 91.34% <93.10%> (+8.01%) ⬆️
tests/optimization/test_bhhh.py 100.00% <100.00%> (ø)
...magic/optimization/subsolvers/_trsbox_quadratic.py 84.55% <0.00%> (-0.82%) ⬇️
src/estimagic/optimization/subsolvers/bntr.py 87.20% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@segsell segsell requested a review from janosg October 21, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant