-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple parallel optimizations #77
Conversation
The code could be a bit shorter if also single optimizations are broadcasted (to lists of length 1). Then this part is not needed:
However, I think it is clearer to make this distinction and don't initialize multiprocessing if it is unnecessary. |
Yes, we should keep single optimization as special case! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes made the code much more readable. Just two questions left, then we can merge. Thanks!
I took care of your remarks and simplified the code once more (the broadcasting function isn't needed anymore) Also n_opts is now just len(arguments). So I suggest to not return it separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks a lot for this PR!
Run several optimizations in parallel (args, criterium etc. are then entered as a list)
First: all relevant arguments need to be entered as a list.