Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpyrize simulation. #148

Merged
merged 118 commits into from
Apr 2, 2019
Merged

Numpyrize simulation. #148

merged 118 commits into from
Apr 2, 2019

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Mar 13, 2019 •
edited

This PR vectorizes pyth_simulate for each period and adds a little bit more documentation.

The main difference is that pyth_simulate now simulates all the agents in one period starting with the first. As the choice of each agent is necessary for the subsequent period, we cannot easily make it faster. But that will never be necessary as it does not take much time.

Appendix

tobiasraabe and others added 30 commits February 6, 2019 21:04
@tobiasraabe
Small formatting.
612fc02
@tobiasraabe
Added hotfix. Needs review.
15f5322
@tobiasraabe
Extract constructing covariates from pyth_calc_rewards_sys to pyth_so…
b3b9a47 
…lve with dataframe.
@tobiasraabe
Reduced pyth_create_state_space to minimum. Working until after covar…
437a6c4 
…iates.
@tobiasraabe
Running until after calculation of systematic rewards.
29d61a3
@tobiasraabe
Small formatting.
99a2fe4
@tobiasraabe
Everything running until pyth_simulate.
519f118
@tobiasraabe
Completed simulation.
ba4f7f8
@tobiasraabe
Estimation done, but could not test it.
3809505
@tobiasraabe
Added notes to delete some functions.
e1feba2
@tobiasraabe
Deleted unnecessary statements.
51d036c
@janosg
Start to fix regression tests.
6f6b1af
@tobiasraabe
fix
6167fbe
@tobiasraabe
Small fixes and added states_indexer object.
f9edc7b
@janosg
Adjustments in clsRespy.
73334af
@janosg
Merge branch 'extract-covariates' into fix_regression_tests
dc74705
@janosg
Simulation runs, estimation not yet because we need an indexer object…
5906db2 
… in pyth_contributions.
@tobiasraabe
Implement states_indexer in simulation, fixed simulated dataset.
f8d6012
@tobiasraabe
Integrated fix_regression_tests, added mail.
02a06a6
@tobiasraabe
implemented state class. maybe running.
14606da
@tobiasraabe
changes.
ebd14de
@tobiasraabe
Minimal changes to make run_regression work (#143)
fb8481e
@tobiasraabe
Merge branch 'janosg' into extract-covariates
98877e8
@tobiasraabe
small fix.
01e00e5
@tobiasraabe
Merge branch 'janosg' into extract-covariates
d28e723
@tobiasraabe
Made regression tests called from respy. Refactored get_total_values,…
d6eaea6 
… construct_emax_risk and get_exogenous_variables. Removed unused functions.
@tobiasraabe
Added numba as dependency.
d8a6396
@tobiasraabe
Solved bug. Regression tests up to 50 working.
90fb3a8
@tobiasraabe
Cleaned last todos.
c8a7d4f
@tobiasraabe
Small fixes.
960eb84
@tobiasraabe tobiasraabe mentioned this pull request Mar 13, 2019
Merged
@tobiasraabe tobiasraabe requested a review from janosg March 20, 2019 08:58
janosg
janosg approved these changes Mar 29, 2019
View reviewed changes
respy/python/simulate/simulate_python.py Outdated Show resolved Hide resolved
@tobiasraabe tobiasraabe mentioned this pull request Mar 31, 2019
Merged
@tobiasraabe tobiasraabe changed the base branch from numpyrize to new-python April 2, 2019 07:57
@tobiasraabe
Copy link
Member Author

I skipped the Travis run again, as it is taking too long.

@tobiasraabe tobiasraabe merged commit c209bf3 into new-python Apr 2, 2019
@tobiasraabe tobiasraabe deleted the numpyrize-simulation branch April 3, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosg janosg janosg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasraabe @janosg