Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement flexible state space #201

Merged
merged 26 commits into from Jun 21, 2019
Merged

Implement flexible state space #201

merged 26 commits into from Jun 21, 2019

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Jun 10, 2019 •
edited

  • Date you used respy PyPackage: June 2019
  • respy version used, if any: > 1.2.1

Current Behavior

The current state space is limited by two factors.

  1. Choices with and without experience are hardcoded.
  2. Differences in initial experiences are only allowed for education.

Solution / Implementation

The new state space has the following properties:

  • A new section in options allows for flexible number of choices like occupation a and b. Education and Home remain necessary components.
  • If an occupation has a wage or experience is inferred from parameters and covariates.
  • Filtering unnecessary states from the state space happens via formulas passed to df.eval.

@tobiasraabe
Added new implementation of create_state_space and test it against ol…
557bf84 
…d implementation. Equality does not strictly hold due to different ordering.
@tobiasraabe tobiasraabe added this to the 2.0.0 milestone Jun 10, 2019
@tobiasraabe tobiasraabe requested a review from janosg June 14, 2019 12:03
janosg
janosg reviewed Jun 16, 2019
View reviewed changes
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good PR and a very pedantic review ;-)

environment.yml Outdated Show resolved Hide resolved
respy/likelihood.py Outdated Show resolved Hide resolved
respy/likelihood.py Outdated Show resolved Hide resolved
respy/pre_processing/data_checking.py Outdated Show resolved Hide resolved
respy/pre_processing/model_processing.py Show resolved Hide resolved
respy/pre_processing/specification_helpers.py Show resolved Hide resolved
respy/shared.py Outdated Show resolved Hide resolved
respy/state_space.py Show resolved Hide resolved
respy/state_space.py Show resolved Hide resolved
respy/tests/random_model.py Outdated Show resolved Hide resolved
@tobiasraabe tobiasraabe requested a review from janosg June 20, 2019 11:38
@tobiasraabe tobiasraabe merged commit 8c8efc6 into develop Jun 21, 2019
@tobiasraabe tobiasraabe deleted the new-state-space branch June 21, 2019 10:47
@tobiasraabe tobiasraabe mentioned this pull request Jun 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosg janosg janosg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasraabe @janosg