New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworking and generalizing types. #211
Conversation
3f404d7
to
3ed2c0f
Compare
…her parameter names (wage_a, etc.).
@janosg There are two issues left on the todo list, but they will break the regression tests because of type sorting. Maybe you can make a review now so that we keep the regression tests for your feedback. After that, I am going to implement the remaining issues and create 100 new regression tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR. All the comments are minor.
@janosg Now, I will start breaking the implementation :). |
… sorting type prob parameters and covariates. Regression tests are failing.
Closes #207, #202.
Current Behavior
See #207 for a discussion on the current state.
Todo
type_probabilities
instead oftype_shares
.type_shares
totype_prob
. Also in optim_paras._validate_params
_sort_type_info
which will break regression tests._sort_type_info
sorts types based on the first parameter which will change with sorting.