Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking and generalizing types. #211

Merged
merged 54 commits into from Jul 17, 2019
Merged

Reworking and generalizing types. #211

merged 54 commits into from Jul 17, 2019

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Jul 6, 2019

  • Date you used respy PyPackage: 06.07.2019
  • respy version used, if any: > 1.2.1
  • Python version, if any: 3.7
  • Operating System: Windows

Closes #207, #202.

Current Behavior

See #207 for a discussion on the current state.

Todo

  • Set target branch to develop once Implement parametrizations of Keane and Wolpin (1997). #209 is merged.
  • Align the current covariates with KW97 by retaining regression tests.
  • The predicted probabilities for each type should be called type_probabilities instead of type_shares.
  • The covariates of the multinomial logit should be matched like choice covariates with parameters.
  • Rename the coefficients of the multinomial logit from type_shares to type_prob. Also in optim_paras.
  • Check _validate_params
  • Random tests run with two or three type probability covariates.
  • Delete _sort_type_info which will break regression tests.
  • Sort type probability parameters so that the order in the frame is not important. Currently, we cannot implement that as _sort_type_info sorts types based on the first parameter which will change with sorting.
  • Added test to ensure sorting of type probability parameters.

@tobiasraabe tobiasraabe changed the base branch from kw1997 to develop July 7, 2019 18:05
@tobiasraabe tobiasraabe force-pushed the types branch 5 times, most recently from 3f404d7 to 3ed2c0f Compare July 9, 2019 12:26
@tobiasraabe
Copy link
Member Author

@janosg There are two issues left on the todo list, but they will break the regression tests because of type sorting. Maybe you can make a review now so that we keep the regression tests for your feedback. After that, I am going to implement the remaining issues and create 100 new regression tests.

Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR. All the comments are minor.

docs/api.rst Outdated Show resolved Hide resolved
respy/config.py Outdated Show resolved Hide resolved
respy/likelihood.py Outdated Show resolved Hide resolved
respy/likelihood.py Outdated Show resolved Hide resolved
respy/likelihood.py Show resolved Hide resolved
respy/likelihood.py Outdated Show resolved Hide resolved
respy/pre_processing/model_processing.py Outdated Show resolved Hide resolved
respy/shared.py Show resolved Hide resolved
respy/simulate.py Outdated Show resolved Hide resolved
@tobiasraabe
Copy link
Member Author

@janosg Now, I will start breaking the implementation :).

@tobiasraabe tobiasraabe requested a review from janosg July 17, 2019 14:45
@tobiasraabe tobiasraabe merged commit 7074b3f into develop Jul 17, 2019
@tobiasraabe tobiasraabe deleted the types branch July 17, 2019 15:08
@tobiasraabe tobiasraabe added this to the 2.0.0 milestone Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants