Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cost parameter for returning to school for KW97 and KW2000. #314

Merged
merged 3 commits into from Jan 23, 2020

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Jan 15, 2020

Current behavior

  • The return to school cost parameter have bad names.
  • Because of that we potentially mixed them up and applied the cost to return to high school (23k) to individuals returning to college (10k).

Desired behavior

Fix it.

Solution / Implementation / References

The parameters are now called returns_to_high_school and returns_to_college which should express that the person has not been to school the previous period and that she has not high school or college diploma, respectively.

A high school diploma is achieved with 12 years of schooling (g(a) >= 12) and a college diploma with 16 years.

The formulas for the parameters are given in the appendix of KW97 as rc1 and rc2:
image

Their description is given in table 8:
image

Todo

  • Review whether the documentation needs to be updated.
  • Document PR in CHANGES.rst.

@tobiasraabe tobiasraabe added this to the 2.0.0 milestone Jan 22, 2020
Copy link
Member

@tostenzel tostenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values in the respy params dataframe returns_to_highschool and returns_to_college, i.e. -2.3283e+4 and -1.07e+4 correspond perfectly to -rc1 and -rc2 in KW97.

@tobiasraabe tobiasraabe merged commit 31ca107 into master Jan 23, 2020
@tobiasraabe tobiasraabe deleted the fix-97-params branch January 23, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants