Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition the state space to parts which are specific to the period, choice set and dense values. #342

Merged
merged 176 commits into from Jul 29, 2020

Conversation

mo2561057
Copy link
Member

@mo2561057 mo2561057 commented Mar 29, 2020

Closes #326.

Current behavior

Currently, we restrict choice sets by introducing inadmissibility penalties.
For more sophisticated model structures this will become very expensive and error-prone.
Moreover, it is not very elegant.

Desired behavior

We want to introduce flexible choice sets.
The user will be able to indicate when choices are admissible and the model solution and simulation will only consider admissible choices at the respective point of the state space.

Solution / Implementation

TBA -- Details will follow soon!

Todo

Moritz

  • Entry in reference guides which explains why mixed choice constraints are neglected for now and what needs to be done to implement them.

Tobias

Both

  • documentation and docstrings.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@tobiasraabe tobiasraabe changed the title Flexible choice sets Partition the state space to parts which are specific to the period, choice set and dense values. Jul 29, 2020
@tobiasraabe tobiasraabe merged commit 01c9c3d into master Jul 29, 2020
@tobiasraabe tobiasraabe deleted the flexible_choice_sets branch July 29, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Todo list for new regression tests
2 participants