Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How-to-guide for estimation exercise with MSM #356

Merged
merged 29 commits into from Jun 24, 2020
Merged

Conversation

amageh
Copy link
Member

@amageh amageh commented May 13, 2020

Current behavior

We currently have a guide to specifying inputs for MSM estimation with respy but no outline of how to actually estimate the model.

Desired behavior

A guide to estimating a model with respy and estimagic.

Solution / Implementation

I will add a notebook with a small estimation exercise to cover the basics. This can be expanded or added to in the future.

Todo

  • Add notebook with estimation exercise to documentation.
  • Document PR in CHANGES.rst.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@tobiasraabe tobiasraabe removed the request for review from mo2561057 May 13, 2020 11:49
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files          45       45           
  Lines        3025     3025           
=======================================
  Hits         2562     2562           
  Misses        463      463           
Flag Coverage Δ
#end_to_end_edge_case 64.95% <ø> (+0.06%) ⬆️
#end_to_end_precise 51.63% <ø> (-2.39%) ⬇️
#end_to_end_rest 71.60% <ø> (-0.53%) ⬇️
#integration_edge_case 42.54% <ø> (ø)
#integration_precise 45.45% <ø> (ø)
#integration_rest 67.17% <ø> (+0.03%) ⬆️
#unit_precise 68.33% <ø> (ø)
#unit_rest 25.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b2602...b05e351. Read the comment docs.

@amageh amageh added documentation method-of-simulated-moments All these issues should be tackled when making respy ready for MSM. labels May 14, 2020
@amageh amageh self-assigned this May 14, 2020
@amageh amageh requested a review from peisenha May 14, 2020 16:06
@tobiasraabe
Copy link
Member

Hi @amageh, please use https://jupyterlab-code-formatter.readthedocs.io/en/latest to format the code inside the notebook.

Copy link
Member

@tobiasraabe tobiasraabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Annica, the notebook is fantastic and pretty in-depth. I had only some minor comments. Feel free to address them whenever you have time.

@tobiasraabe tobiasraabe added this to the 2.0.0 milestone Jun 10, 2020
@tobiasraabe
Copy link
Member

tobiasraabe commented Jun 24, 2020

@amageh Anything left? Otherwise, hit the merge button :)

@tobiasraabe tobiasraabe self-requested a review June 24, 2020 11:42
Copy link
Member

@tobiasraabe tobiasraabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🎉!

@amageh amageh merged commit 8fb546e into master Jun 24, 2020
@amageh amageh deleted the estimation-exercise branch June 24, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation method-of-simulated-moments All these issues should be tackled when making respy ready for MSM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants