Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulation with data and add tests. #383

Merged
merged 2 commits into from Oct 30, 2020
Merged

Conversation

janosg
Copy link
Member

@janosg janosg commented Oct 7, 2020

Current behavior

Simulation with data leads to an error

Solution / Implementation

Convert categorical columns to numerical values where necessary.

@janosg janosg removed the request for review from tobiasraabe October 7, 2020 10:13
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@03f9a98). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage        ?   86.01%           
=======================================
  Files           ?       48           
  Lines           ?     3426           
  Branches        ?        0           
=======================================
  Hits            ?     2947           
  Misses          ?      479           
  Partials        ?        0           
Flag Coverage Δ
#end_to_end 75.27% <100.00%> (?)
#integration 65.38% <46.15%> (?)
#unit 69.84% <46.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
respy/simulate.py 95.12% <100.00%> (ø)
respy/tests/test_simulate.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f9a98...ff6bc98. Read the comment docs.

@amageh amageh merged commit 825b03f into main Oct 30, 2020
@amageh amageh deleted the fix-simulation-with-data branch October 30, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants