Remove direct estimagic dependencies to avoid circular imports #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove direct estimagic dependencies to avoid circular imports
The benchmarks change slightly. This is expected, as the optimization in the optimal sampler changed:
I think we can ignore this. The changes are smaller than differences we get between computers.
Old parallel ls
New parallel ls
Old noisy ls
New noisy ls
Old ls
New ls
Old scalar
New scalar