Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance in parallel case #9

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Improve performance in parallel case #9

merged 10 commits into from
Jan 19, 2024

Conversation

timmens
Copy link
Member

@timmens timmens commented Jan 19, 2024

In this PR, we improve the performance in the parallel case.

More specifically, we

  • Consider sampled line search points when drawing a speculative sample
  • Set the radius from which we draw the speculative sample to 75% of the trust-region radius
  • Add the filter option n_max_factor that allows us to compute a target size for the filtering step dependent on the regular target size

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a94c8b5) 78.48% compared to head (cb35dec) 78.64%.

Files Patch % Lines
src/tranquilo/acceptance_decision.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   78.48%   78.64%   +0.15%     
==========================================
  Files          68       68              
  Lines        4923     4944      +21     
==========================================
+ Hits         3864     3888      +24     
+ Misses       1059     1056       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timmens timmens merged commit 0f3d567 into main Jan 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants