Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TC 0.14.1 #778

Merged
merged 2 commits into from Dec 19, 2017
Merged

Upgrade to TC 0.14.1 #778

merged 2 commits into from Dec 19, 2017

Conversation

hdoupe
Copy link
Collaborator

@hdoupe hdoupe commented Dec 17, 2017

Upgrades PolicyBrain to TC 0.14.1.

@martinholmer @MattHJensen Do you agree with doing this upgrade? Do you think there will be another TC release in the coming days that I should wait for? Also, are there any presets that you would like to add?

@MattHJensen
Copy link
Contributor

MattHJensen commented Dec 18, 2017

@hdoupe, I think this is a good update.

#765 is currently blocking us from adding additional presets.

#763 is also blocking us from adding a TCJA reconciliation preset, I believe.

Edit: Added note about #763

@hdoupe
Copy link
Collaborator Author

hdoupe commented Dec 18, 2017

@MattHJensen Ok, sounds good. I'll take a look at #765 today. That seems like a quicker fix than #763.

@hdoupe
Copy link
Collaborator Author

hdoupe commented Dec 18, 2017

In PSLmodels/Tax-Calculator#1771 @MaxGhenis asked

Is there an issue for updating TaxBrain to 0.14.1 I can track?

This is the issue that you would want to track. This PR will be on the test app shortly. Hopefully, It will be in production tonight or tomorrow night.

@hdoupe
Copy link
Collaborator Author

hdoupe commented Dec 19, 2017

Merging #778 to get ready for Tax-Calculator 0.14.2.

@hdoupe hdoupe merged commit c58b936 into ospc-org:master Dec 19, 2017
@MaxGhenis
Copy link
Contributor

Just checking on this, as I'm still getting the same 500 error as reported in PSLmodels/Tax-Calculator#1771 when uploading TCJA. Any ETA, or could I use the test app?

@hdoupe
Copy link
Collaborator Author

hdoupe commented Dec 22, 2017

@MaxGhenis Thanks for checking in. The test app is running Tax-Caclulator 0.14.2. It's slower than the production app, but otherwise they are the same. Note that this is the testing app and some of the bug fixes/new features may still need some touching up.

Since you are using the test app, feel free to test out the bug fixes and new features listed in 1.2.2 in the RELEASES.md + PR #788.

Here's a link to the app: http://ospc-taxes7.herokuapp.com/taxbrain/

@hdoupe
Copy link
Collaborator Author

hdoupe commented Dec 22, 2017

Also, the production site will most likely be updated tomorrow with Tax-Calculator 0.14.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants