Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 Internal Server Error when uploading TCJA_Reconciliation.json to TaxBrain #1771

Closed
MaxGhenis opened this issue Dec 18, 2017 · 5 comments
Closed

Comments

@MaxGhenis
Copy link
Contributor

I uploaded TCJA_Reconciliation.json to https://www.ospc.org/taxbrain/file/, which takes me to https://www.ospc.org/taxbrain/file/?start_year=2017 where it says

500 Internal Server Error!

This error arises both when providing and not providing a behavior file, and when choosing Show me the results! and Quick calculation!.

I don't get the error when uploading the older TCJA_Senate.json, though the difference table is all zeros (https://www.ospc.org/taxbrain/26994/).

@MaxGhenis
Copy link
Contributor Author

I see here that TCJA_Reconciliation requires Tax-Calculator version 0.14.1, while TaxBrain is on version 0.14.0 per my just-produced Senate result.

Is there an issue for updating TaxBrain to 0.14.1 I can track?

If possible, a more informative error message would be nice here, e.g. saying the reform includes parameters not available in the current version.

@martinholmer
Copy link
Collaborator

@MaxGhenis, Thanks for your reports on problems using TaxBrain to analyze the conference committee's TCJA bill. I think TaxBrain will soon be using Tax-Calculator release 0.14.1, which should eliminate the problems you're having. You can follow the progress of TaxBrain at this GitHub repository.

@MaxGhenis also said:

If possible, a more informative error message would be nice here, e.g. saying the reform includes parameters not available in the current version.

Yes, that would be better than the uninformative 500 Internal Server Error!.
I'll suggest that to the TaxBrain developers. @hdoupe and/or @GoFroggyRun, can you open an enhancement issue on this topic?

@martinholmer
Copy link
Collaborator

I'm going to close issue #1771 now that it is on the radar scope of the TaxBrain developers.

@MaxGhenis
Copy link
Contributor Author

Ah, I didn't realize PolicyBrain included TaxBrain. Would it be worth mentioning that front-end issues should be checked/reported there in https://github.com/open-source-economics/Tax-Calculator/blob/master/docs/contributing.md ?

@hdoupe
Copy link
Collaborator

hdoupe commented Dec 18, 2017

@MaxGhenis said

Ah, I didn't realize PolicyBrain included TaxBrain.

Yes, PolicyBrain includes TaxBrain. The PolicyBrain codebase is a little complicated right now. So, it's understandable that you didn't find TaxBrain in that mess. You can follow progress on this issue in ospc-org/ospc.org#779.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants