Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework master getStats() #116

Merged
merged 1 commit into from
Oct 15, 2017
Merged

rework master getStats() #116

merged 1 commit into from
Oct 15, 2017

Conversation

jupe
Copy link
Contributor

@jupe jupe commented Oct 15, 2017

Status

READY

Migrations

NO

Description

  • This changes stats structure a bit to support more details clearer way
    adds
  • add more jsdoc for function
  • update unit tests

Related PRs

#94 (extracted from here)

Todos

  • Tests
  • Documentation

* This changes stats structure a bit to support more details clearer way
  adds
* add more jsdoc for function
* update unit tests
@jupe jupe added this to the v0.5.0 milestone Oct 15, 2017
@jupe jupe changed the title rework master getStats() a bit to use promises and more details rework master getStats() Oct 15, 2017
* },
* hostname: 'opentmi-host',
* os: 'linux',
* osStats: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to separate these "dynamic" values to behind own API, but lets continue with this for now..

@jupe jupe merged commit 1b3e377 into master Oct 15, 2017
@jupe jupe deleted the master_stats branch October 15, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant