Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the character `/' in tag values. #14

Closed
tsuna opened this issue Feb 25, 2011 · 3 comments
Closed

Allow the character `/' in tag values. #14

tsuna opened this issue Feb 25, 2011 · 3 comments

Comments

@tsuna
Copy link
Member

tsuna commented Feb 25, 2011

There's not reason why / cannot be allowed in tag values, and there are a few places where it would be useful (e.g. the df collector where we store mount points). To keep the implementation simple, we'll probably also allow / in metric names and tag names a I believe they share the same validation regexp.

@jtakkala
Copy link
Contributor

Is there any reason this could not be implemented? It seems to be a one-line change in src/core/Tags.java. I've tested it on my branch and works fine, but there may be corner cases I'm not aware of.

The only other place that would need changing is the UI, which seems to do input validation. I'm not quite sure what file to modify for that.

@tsuna
Copy link
Member Author

tsuna commented Mar 31, 2011

This is a very simple issue indeed. Probably a 2-3 line change. As you noted, validateString in src/core/Tags.java needs to be updated and the validation regexp in the UI are in src/tsd/client/MetricForm.java. I think that's all that needs to be done. Feel free to propose a patch, I'll be happy to review it and integrate it.

@jtakkala
Copy link
Contributor

jtakkala commented Apr 3, 2011

Allow `/'in tag and metric names.

Closed by 7d33f75.

Change-Id: Ia1234902f5b0b7a36d20545c93ce53d91f128410
Reviewed-by: Benoit Sigoure <tsuna@stumbleupon.com>
Tested-by: Benoit Sigoure <tsuna@stumbleupon.com>

@tsuna tsuna closed this as completed Apr 3, 2011
tsuna pushed a commit to tsuna/opentsdb that referenced this issue Apr 20, 2011
Closes OpenTSDB#14.

Change-Id: Ia1234902f5b0b7a36d20545c93ce53d91f128410
Reviewed-by: Benoit Sigoure <tsuna@stumbleupon.com>
Tested-by: Benoit Sigoure <tsuna@stumbleupon.com>
jzeeck added a commit to jzeeck/opentsdb that referenced this issue Aug 26, 2014
De-duplicate the parsing of uniqueid type strings and type handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants