-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the character `/' in tag values. #14
Comments
Is there any reason this could not be implemented? It seems to be a one-line change in src/core/Tags.java. I've tested it on my branch and works fine, but there may be corner cases I'm not aware of. The only other place that would need changing is the UI, which seems to do input validation. I'm not quite sure what file to modify for that. |
This is a very simple issue indeed. Probably a 2-3 line change. As you noted, |
Allow `/'in tag and metric names. Closed by 7d33f75. Change-Id: Ia1234902f5b0b7a36d20545c93ce53d91f128410 |
Closes OpenTSDB#14. Change-Id: Ia1234902f5b0b7a36d20545c93ce53d91f128410 Reviewed-by: Benoit Sigoure <tsuna@stumbleupon.com> Tested-by: Benoit Sigoure <tsuna@stumbleupon.com>
De-duplicate the parsing of uniqueid type strings and type handling
There's not reason why
/
cannot be allowed in tag values, and there are a few places where it would be useful (e.g. thedf
collector where we store mount points). To keep the implementation simple, we'll probably also allow/
in metric names and tag names a I believe they share the same validation regexp.The text was updated successfully, but these errors were encountered: